Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded and improved editor features #1744

Closed
wants to merge 8 commits into from
Closed

Upgraded and improved editor features #1744

wants to merge 8 commits into from

Conversation

rezaei92
Copy link

Hello,
It seems that due to issues and the absence of certain features in the editor, which have been frequently mentioned in various issues, it would be better to make changes and developments in this section and upgrade the Squire editor version along with it. Some of the issues include the lack of text alignment, problems with text direction, the inability to add text styles as inline CSS, issues with directly copying tables, and visual and display problems.

Therefore, implementing these changes will address many needs, especially for RTL languages. I would appreciate it if you could accept this PR to improve performance and provide more convenience for users.

image

@rezaei92 rezaei92 changed the title Upgrade and improved editor features Upgraded and improved editor features Sep 11, 2024
@phsc84
Copy link

phsc84 commented Sep 11, 2024

Great work, would love to give it a try!
Just a sidenote: Squire 2.3.2 is already out.

@rezaei92
Copy link
Author

Great work, would love to give it a try! Just a sidenote: Squire 2.3.2 is already out.

Thanks for your feedback. I've done.

@the-djmaze
Copy link
Owner

the-djmaze commented Sep 14, 2024 •
edited
Loading

Yes, it would be nice if Squire-RTE can be used.
However, there are several caveats why it is not used.
I will try to document them better, here https://github.com/the-djmaze/Squire/commits/snappymail/

But i also see you added DOMPurify.
Can you remove DOMPurify?

@rezaei92
Copy link
Author

Thank you so much.
I removed it.

the-djmaze pushed a commit that referenced this pull request Sep 15, 2024
RTL language improvement from #1744 by @rezaei92
947ce59
@the-djmaze
Copy link
Owner

the-djmaze commented Sep 15, 2024 •
edited
Loading

Ok, Squire-RTE can't be used by default due to the important changes.
If you are missing something, see https://github.com/the-djmaze/Squire

A good example why SnappyMail uses a modified Squire is this issue #962

  1. Drag&drop the attached email into a mailbox.
  2. Open the email
  3. Hit reply button

Now see the difference in speed with Squire-RTE and ours.

Feel free to create a new PR with only the RTL fixes.

@the-djmaze the-djmaze closed this Sep 15, 2024
This was referenced Sep 16, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rezaei92 @phsc84 @the-djmaze